Ticket modified by Klaus Leithoff at 2009/02/12 17:16
Tracking System: Bugs
Category: Timesheet
Version: Version 1.6.001
Status: Closed
Resolution:
Completed: 100%
Priority: 5 - medium
Created By: Martin Nitram
Assigned to: Klaus Leithoff
Summary: #1876 - Timesheet, in detail view, not shows link to the owner project
Hello Ralf,
this is the bug 1821 that was closed automatically as Jiri did not answer in the time.
I took it over, because I am experiencing the same problem too:
“After upgrade from 1.4 to 1.6rc3. Timesheet, in detail view, not shows link to the owner project, for all item.”
My concern is that when I showed a list of timesheets in 1.4, every line/timesheet had an “header” with the name of project that is linked from.
So I could see if my timesheets are really related for the project or switch this view off with “Details” or “no Details”.
But now is the view the same, switching between “Details” or “no Details” does no more matter.
I can provide screenshots or further explanations. when needed
Martin
Comment by Klaus Leithoff at 2009/02/12 17:16:
This bug is fixed in our subversion repository now.
You can update via subversion with the following commands:
cd /path/to/egroupware
svn update * # mind the */asterisk
To check if you have svn installed try running svn version. To install the svn command under Linux install the package “subversion”. For Windows you can use eg. TortoiseSVN (http://tortoisesvn.tigris.org).
Revision 26549
Sponsored by Martin Nitram
Comment by Klaus Leithoff at 2009/02/02 11:10:
commited that to trunk.
If noone objects, I will commit that to 1.6 later that week.
Comment by Klaus Leithoff at 2009/01/27 16:42:
This would do the trick (replacing line 507 with the following block):
$links3 = egw_link::get_links_multiple(TIMESHEET_APP,$ids,true,'projectmanager'); // only check for pm links!
#_debug_array($links);
//as the full array is expected, we must supply the missing but needed (since expected further down) information
if (is_array($links3)) {
foreach ($links3 as $likey => $liarray) {
#echo "$likey";_debug_array($liarray);echo"";
if (is_array($liarray)) {
foreach ($liarray as $li2key => $lival) {
$links[$likey][$li2key]['id'] = $lival;
$links[$likey][$li2key]['app'] = 'projectmanager';
}
}
}
}
Comment by Klaus Leithoff at 2009/01/27 15:59:
Hmm, the one in egw_links breaks stuff somewhere else, since the behavior of returning
either just the links or the full arrays of the link is expected elsewhere. So a closer look is needed
Comment by Klaus Leithoff at 2009/01/19 17:10:
ReChecked that.
The cause for the problem is in phpgwapi/inc/class.solink.inc.php
At least, thats what I think. I test that a bit more, and have a look.
Index: phpgwapi/inc/class.solink.inc.php
— phpgwapi/inc/class.solink.inc.php (Revision 26525)
+++ phpgwapi/inc/class.solink.inc.php (Arbeitskopie)
@@ -160,7 +160,8 @@
{
return;
}
-
$links[$app_id][$row['link_id']] = $only_app && !$not_only ? $linked_id : array(
-
#$links[$app_id][$row['link_id']] = $only_app && !$not_only ? $linked_id : array( -
$links[$app_id][$row['link_id']] = array( 'app' => $linked_app, 'id' => $linked_id, 'remark' => $row['link_remark'],
Comment by Klaus Leithoff at 2009/01/16 11:17:
I will commit that to trunk, and have a look, …
If there are no complications, I will apply that to 1.6
regards
Klausi
Comment by Martin Nitram at 2009/01/04 16:37:
Hello Pius,
yes, it works great! Thank you very much.
Martin
Comment by Pius Tschümperlin at 2009/01/01 16:36:
timesheet\inc\class.timesheet_ui.inc.php line 507
$links = egw_link::get_links_multiple(TIMESHEET_APP,$ids,true,‘projectmanager’); // only check for pm links!
change to:
$links = egw_link::get_links_multiple(TIMESHEET_APP,$ids,true);
Linked entries:
http://www.egroupware.org/egroupware/index.php?menuaction=tracker.tracker_ui.edit&tr_id=1876&no_popup=1